Merge pull request #8660 from koic/fix_a_false_positive_for_class_and…

…_module_children

Fix a false positive for `Style/ClassAndModuleChildren`

CHANGELOG.md

@@ -15,6 +15,7 @@
 * [#8653](https://github.com/rubocop-hq/rubocop/pull/8653): Fix a false positive for `Layout/DefEndAlignment` when using refinements and `private def`. ([@koic][])
 * [#8655](https://github.com/rubocop-hq/rubocop/pull/8655): Fix a false positive for `Style/ClassAndModuleChildren` when using cbase class name. ([@koic][])
 * [#8654](https://github.com/rubocop-hq/rubocop/pull/8654): Fix a false positive for `Style/SafeNavigation` when checking `foo&.empty?` in a conditional. ([@koic][])
+* [#8660](https://github.com/rubocop-hq/rubocop/pull/8660): Fix a false positive for `Style/ClassAndModuleChildren` when using cbase module name. ([@koic][])
 
 ### Changes
 

lib/rubocop/cop/style/class_and_module_children.rb

@@ -32,7 +32,6 @@ class ClassAndModuleChildren < Base
                       'nested style.'
 
         def on_class(node)
-          return if node.identifier.children[0]&.cbase_type?
           return if node.parent_class && style != :nested
 
           check_style(node, node.body)
@@ -113,6 +112,8 @@ def indent_width
         end
 
         def check_style(node, body)
+          return if node.identifier.children[0]&.cbase_type?
+
           if style == :nested
             check_nested_style(node)
           else

spec/rubocop/cop/style/class_and_module_children_spec.rb

@@ -67,6 +67,13 @@ class ::Foo
       RUBY
     end
 
+    it 'accepts cbase module name' do
+      expect_no_offenses(<<~RUBY)
+        module ::Foo
+        end
+      RUBY
+    end
+
     it 'accepts :: in parent class on inheritance' do
       expect_no_offenses(<<~RUBY)
         class FooClass