[Fix #9551] Fix a false positive for Style/UnlessLogicalOperators

Fixes #9551.

This PR fixes a false positive for `Style/UnlessLogicalOperators`
when using `||` operator and invoked method name includes "or"
in the conditional branch.

This is an issue due to string matching of source code instead of AST.

changelog/fix_false_positive_for_style_unless_logical_operators.md

@@ -0,0 +1 @@
+* [#9551](https://github.com/rubocop/rubocop/issues/9551): Fix a false positive for `Style/UnlessLogicalOperators` when using `||` operator and invoked method name includes "or" in the conditional branch. ([@koic][])

lib/rubocop/cop/style/unless_logical_operators.rb

@@ -87,11 +87,17 @@ def mixed_logical_operator?(node)
         end
 
         def mixed_precedence_and?(node)
-          node.source.include?('&&') && node.source.include?('and')
+          and_sources = node.condition.each_descendant(:and).map(&:operator)
+          and_sources << node.condition.operator if node.condition.and_type?
+
+          !(and_sources.all? { |s| s == '&&' } || and_sources.all? { |s| s == 'and' })
         end
 
         def mixed_precedence_or?(node)
-          node.source.include?('||') && node.source.include?('or')
+          or_sources = node.condition.each_descendant(:or).map(&:operator)
+          or_sources << node.condition.operator if node.condition.or_type?
+
+          !(or_sources.all? { |s| s == '||' } || or_sources.all? { |s| s == 'or' })
         end
       end
     end

spec/rubocop/cop/style/unless_logical_operators_spec.rb

@@ -116,6 +116,26 @@ def condition?
         return unless a?
       RUBY
     end
+
+    it 'does not register an offense when using `||` operator and invoked method name includes "or" in the conditional branch' do
+      expect_no_offenses(<<~RUBY)
+        unless condition
+          includes_or_in_the_name
+
+          foo || bar
+        end
+      RUBY
+    end
+
+    it 'does not register an offense when using `&&` operator and invoked method name includes "and" in the conditional branch' do
+      expect_no_offenses(<<~RUBY)
+        unless condition
+          includes_and_in_the_name
+
+          foo && bar
+        end
+      RUBY
+    end
   end
 
   context 'EnforcedStyle is `forbid_logical_operators`' do