Merge pull request #8526 from koic/fix_false_positive_for_style_case_…

…equality

Fix a false positive for `Style/CaseEquality` cop

CHANGELOG.md

@@ -33,6 +33,7 @@
 * [#8698](https://github.com/rubocop-hq/rubocop/pull/8698): Fix cache to avoid encoding exception. ([@marcandre][])
 * [#8704](https://github.com/rubocop-hq/rubocop/issues/8704): Fix an error for `Lint/AmbiguousOperator` when using safe navigation operator with a unary operator. ([@koic][])
 * [#8661](https://github.com/rubocop-hq/rubocop/pull/8661): Fix an incorrect auto-correct for `Style/MultilineTernaryOperator` when returning a multiline ternary operator expression. ([@koic][])
+* [#8526](https://github.com/rubocop-hq/rubocop/pull/8526): Fix a false positive for `Style/CaseEquality` cop when the receiver is not a camel cased constant. ([@koic][])
 
 ### Changes
 

lib/rubocop/cop/style/case_equality.rb

@@ -39,6 +39,8 @@ class CaseEquality < Base
 
         def on_send(node)
           case_equality?(node) do |lhs, rhs|
+            return if lhs.const_type? && !lhs.module_name?
+
             add_offense(node.loc.selector) do |corrector|
               replacement = replacement(lhs, rhs)
               corrector.replace(node, replacement) if replacement

rubocop.gemspec

@@ -38,7 +38,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('rainbow', '>= 2.2.2', '< 4.0')
   s.add_runtime_dependency('regexp_parser', '>= 1.7')
   s.add_runtime_dependency('rexml')
-  s.add_runtime_dependency('rubocop-ast', '>= 0.3.0', '< 1.0')
+  s.add_runtime_dependency('rubocop-ast', '>= 0.4.0', '< 1.0')
   s.add_runtime_dependency('ruby-progressbar', '~> 1.7')
   s.add_runtime_dependency('unicode-display_width', '>= 1.4.0', '< 2.0')
 

spec/rubocop/cop/style/case_equality_spec.rb

@@ -8,6 +8,12 @@
       RUBY
     end
 
+    it 'does not register an offense for === when the receiver is not a camel cased constant' do
+      expect_no_offenses(<<~RUBY)
+        REGEXP_CONSTANT === var
+      RUBY
+    end
+
     it 'registers an offense and corrects for === when the receiver is a regexp' do
       expect_offense(<<~RUBY)
         /OMG/ === var