Merge pull request #11573 from fatkodima/out_of_range_regexp_ref-hash…

…es-pins

Handle hash patterns and pins in `Lint/OutOfRangeRegexpRef` cop

changelog/change_out_of_range_regexp_ref_handle_hashes_and_pins.md

@@ -0,0 +1 @@
+* [#11573](https://github.com/rubocop/rubocop/pull/11573): Handle hash patterns and pins in `Lint/OutOfRangeRegexpRef` cop. ([@fatkodima][])

lib/rubocop/cop/lint/out_of_range_regexp_ref.rb

@@ -69,7 +69,7 @@ def on_when(node)
         end
 
         def on_in_pattern(node)
-          regexp_patterns = patterns(node).select(&:regexp_type?)
+          regexp_patterns = regexp_patterns(node)
 
           @valid_ref = regexp_patterns.map { |pattern| check_regexp(pattern) }.compact.max
         end
@@ -90,16 +90,12 @@ def on_nth_ref(node)
 
         private
 
-        def patterns(pattern_node)
-          pattern = pattern_node.node_parts[0]
-
-          case pattern.type
-          when :array_pattern, :match_alt
-            pattern.children
-          when :match_as
-            patterns(pattern)
-          else
+        def regexp_patterns(in_node)
+          pattern = in_node.pattern
+          if pattern.regexp_type?
             [pattern]
+          else
+            pattern.each_descendant(:regexp).to_a
           end
         end
 

spec/rubocop/cop/lint/out_of_range_regexp_ref_spec.rb

@@ -234,6 +234,50 @@
       end
     end
 
+    context 'matching hashes' do
+      it 'does not register an offense when in range references are used' do
+        expect_no_offenses(<<~RUBY)
+          case hash
+          in a: /(foo)(bar)/
+            $2
+          end
+        RUBY
+      end
+
+      it 'registers an offense when out of range references are used' do
+        expect_offense(<<~RUBY)
+          case hash
+          in a: /(foo)(bar)/, b: /(bar)baz/
+            $3
+            ^^ $3 is out of range (2 regexp capture groups detected).
+          end
+        RUBY
+      end
+    end
+
+    context 'matching pins' do
+      it 'does not register an offense when in range references are used' do
+        expect_no_offenses(<<~RUBY)
+          a = 1
+          case array
+          in [^a, /(foo)(bar)/]
+            $2
+          end
+        RUBY
+      end
+
+      it 'registers an offense when out of range references are used' do
+        expect_offense(<<~RUBY)
+          a = 1
+          case array
+          in [^a, /(foo)(bar)/, /(foo)bar/]
+            $3
+            ^^ $3 is out of range (2 regexp capture groups detected).
+          end
+        RUBY
+      end
+    end
+
     context 'matching with aliases' do
       context 'variable aliases' do
         it 'does not register an offense when in range references are used' do