[Fix #10462] Fix an incorrect autocorrect for Lint/SymbolConversion

Fixes #10462. This PR fixes an incorrect autocorrect for `Lint/SymbolConversion` when using a quoted symbol key with hash rocket.
rubocop · Mar 22, 2022 · 5234ad4 · 5234ad4
1 parent 3112ce7
commit 5234ad4
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/changelog/fix_an_incorrect_autocorrect_for_lint_symbol_conversion.md b/changelog/fix_an_incorrect_autocorrect_for_lint_symbol_conversion.md
@@ -0,0 +1 @@
+* [#10462](https://github.com/rubocop/rubocop/issues/10462): Fix an incorrect autocorrect for `Lint/SymbolConversion` when using a quoted symbol key with hash rocket. ([@koic][])
diff --git a/lib/rubocop/cop/lint/symbol_conversion.rb b/lib/rubocop/cop/lint/symbol_conversion.rb
@@ -147,13 +147,14 @@ def correct_hash_key(node)
           # will be ignored.
           return unless node.value.to_s.match?(/\A[a-z0-9_]/i)
 
-          correction = node.value.inspect.delete_prefix(':')
+          correction = node.value.inspect
+          correction = correction.delete_prefix(':') if node.parent.colon?
           return if properly_quoted?(node.source, correction)
 
           register_offense(
             node,
             correction: correction,
-            message: format(MSG, correction: "#{correction}:")
+            message: format(MSG, correction: node.parent.colon? ? "#{correction}:" : correction)
           )
         end
 

diff --git a/spec/rubocop/cop/lint/symbol_conversion_spec.rb b/spec/rubocop/cop/lint/symbol_conversion_spec.rb
@@ -121,7 +121,18 @@
         RUBY
       end
 
-      it 'registers an offense for a quoted symbol' do
+      it 'registers an offense for a quoted symbol key' do
+        expect_offense(<<~RUBY)
+          { :'foo' => :bar }
+            ^^^^^^ Unnecessary symbol conversion; use `:foo` instead.
+        RUBY
+
+        expect_correction(<<~RUBY)
+          { :foo => :bar }
+        RUBY
+      end
+
+      it 'registers an offense for a quoted symbol value' do
         expect_offense(<<~RUBY)
           { foo: :'bar' }
                  ^^^^^^ Unnecessary symbol conversion; use `:bar` instead.