Mark Style/HashExcept as unsafe

rubocop · Nov 8, 2022 · 4c5b303 · 4c5b303
1 parent cb29d08
commit 4c5b303
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/changelog/change_mark_style_hash_except_as_unsafe.md b/changelog/change_mark_style_hash_except_as_unsafe.md
@@ -0,0 +1 @@
+* [#11163](https://github.com/rubocop/rubocop/pull/11163): Mark `Style/HashExcept` as unsafe. ([@r7kamura][])
diff --git a/config/default.yml b/config/default.yml
@@ -3820,8 +3820,9 @@ Style/HashExcept:
                  Checks for usages of `Hash#reject`, `Hash#select`, and `Hash#filter` methods
                  that can be replaced with `Hash#except` method.
   Enabled: pending
+  Safe: false
   VersionAdded: '1.7'
-  VersionChanged: '1.31'
+  VersionChanged: '<<next>>'
 
 Style/HashLikeCase:
   Description: >-

diff --git a/lib/rubocop/cop/style/hash_except.rb b/lib/rubocop/cop/style/hash_except.rb
@@ -13,6 +13,10 @@ module Style
       # when used `==`.
       # And do not check `Hash#delete_if` and `Hash#keep_if` to change receiver object.
       #
+      # @safety
+      #   This cop is unsafe because it cannot be guaranteed that the receiver
+      #   is a `Hash` or responds to the replacement method.
+      #
       # @example
       #
       #   # bad