Merge pull request #9970 from mtsmfm/sort-with-arg

Don't register an offense when sort method has arguments

changelog/fix_redundant_sort_false_positive.md

@@ -0,0 +1 @@
+* [#9970](https://github.com/rubocop/rubocop/pull/9970): Don't register an offense when sort method has arguments for `Style/RedundantSort` cop. ([@mtsmfm][])

lib/rubocop/cop/style/redundant_sort.rb

@@ -60,8 +60,8 @@ class RedundantSort < Base
         # @!method redundant_sort?(node)
         def_node_matcher :redundant_sort?, <<~MATCHER
           {
-            (send $(send _ $:sort ...) ${:last :first})
-            (send $(send _ $:sort ...) ${:[] :at :slice} {(int 0) (int -1)})
+            (send $(send _ $:sort) ${:last :first})
+            (send $(send _ $:sort) ${:[] :at :slice} {(int 0) (int -1)})
 
             (send $(send _ $:sort_by _) ${:last :first})
             (send $(send _ $:sort_by _) ${:[] :at :slice} {(int 0) (int -1)})

spec/rubocop/cop/style/redundant_sort_spec.rb

@@ -206,6 +206,11 @@
     expect_no_offenses('[1, 2, 3].sort.first(1)')
   end
 
+  # Some gems like mongo provides sort method with an argument
+  it 'does not register an offense when sort has an argument' do
+    expect_no_offenses('mongo_client["users"].find.sort(_id: 1).first')
+  end
+
   it 'does not register an offense for sort!.first' do
     expect_no_offenses('[1, 2, 3].sort!.first')
   end
@@ -240,6 +245,10 @@
     it 'does not register an offense when at(-2) is called on sort_by' do
       expect_no_offenses('[1, 2, 3].sort_by(&:foo).at(-2)')
     end
+
+    it 'does not register an offense when [-1] is called on sort with an argument' do
+      expect_no_offenses('mongo_client["users"].find.sort(_id: 1)[-1]')
+    end
   end
 
   context '>= Ruby 2.7', :ruby27 do