Merge pull request #10187 from koic/fix_false_positive_for_lint_ambig…

…uous_range [Fix #10185] Fix a false positive for `Lint/AmbiguousRange`
rubocop · Oct 14, 2021 · 41f2632 · 41f2632
2 parents e9c339b + 96457ee
commit 41f2632
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/changelog/fix_false_positive_for_lint_ambiguous_range.md b/changelog/fix_false_positive_for_lint_ambiguous_range.md
@@ -0,0 +1 @@
+* [#10185](https://github.com/rubocop/rubocop/issues/10185): Fix a false positive for `Lint/AmbiguousRange` when using `self` in a range literal. ([@koic][])
diff --git a/lib/rubocop/cop/lint/ambiguous_range.rb b/lib/rubocop/cop/lint/ambiguous_range.rb
@@ -82,7 +82,7 @@ def each_boundary(range)
         def acceptable?(node)
           node.begin_type? ||
             node.basic_literal? ||
-            node.variable? || node.const_type? ||
+            node.variable? || node.const_type? || node.self_type? ||
             (node.call_type? && acceptable_call?(node))
         end
 

diff --git a/spec/rubocop/cop/lint/ambiguous_range_spec.rb b/spec/rubocop/cop/lint/ambiguous_range_spec.rb
@@ -74,6 +74,13 @@
         RUBY
       end
 
+      it 'does not register an offense for `self`' do
+        expect_no_offenses(<<~RUBY)
+          self#{operator}42
+          42#{operator}self
+        RUBY
+      end
+
       it 'can handle an endless range', :ruby26 do
         expect_offense(<<~RUBY)
           x || 1#{operator}