Merge pull request #10429 from issyl0/style/for-unsafe

[Fix #10427] Style/For: Mark auto-correction as unsafe
rubocop · Feb 21, 2022 · 3021297 · 3021297
2 parents aa47871 + fde1653
commit 3021297
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/changelog/change_mark_style_for_as_unsafe.md b/changelog/change_mark_style_for_as_unsafe.md
@@ -0,0 +1 @@
+* [#10427](https://github.com/rubocop/rubocop/issues/10427): Mark `Style/For` as unsafe auto-correction. ([@issyl0][])
diff --git a/config/default.yml b/config/default.yml
@@ -3544,8 +3544,9 @@ Style/For:
   Description: 'Checks use of for or each in multiline loops.'
   StyleGuide: '#no-for-loops'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.13'
-  VersionChanged: '0.59'
+  VersionChanged: '<<next>>'
   EnforcedStyle: each
   SupportedStyles:
     - each

diff --git a/lib/rubocop/cop/style/for.rb b/lib/rubocop/cop/style/for.rb
@@ -38,6 +38,10 @@ module Style
       #     end
       #   end
       #
+      # @safety
+      #   This cop's autocorrection is unsafe because the scope of
+      #   variables is different between `each` and `for`.
+      #
       class For < Base
         include ConfigurableEnforcedStyle
         include RangeHelp