Skip to content

Commit

Permalink
Tweak a message for rake new_cop
Browse files Browse the repository at this point in the history
Follow up to "Wrote good commit messages." of PULL_REQUEST_TEMPLATE.md.
https://github.com/rubocop/rubocop/blob/v1.22.3/.github/PULL_REQUEST_TEMPLATE.md

Refer: "4. Do not end the subject line with a period"
https://chris.beams.io/posts/git-commit/#end
  • Loading branch information
koic committed Oct 28, 2021
1 parent b7bab5f commit 25c95e6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/development.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Do 4 steps:
1. Modify the description of Department/Name in config/default.yml
2. Implement your new cop in the generated file!
3. Commit your new cop with a message such as
e.g. "Add new `Department/Name` cop."
e.g. "Add new `Department/Name` cop"
4. Run `bundle exec rake changelog:new` to generate a changelog entry
for your new cop.
Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/cop/generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def todo
1. Modify the description of #{badge} in config/default.yml
2. Implement your new cop in the generated file!
3. Commit your new cop with a message such as
e.g. "Add new `#{badge}` cop."
e.g. "Add new `#{badge}` cop"
4. Run `bundle exec rake changelog:new` to generate a changelog entry
for your new cop.
TODO
Expand Down
2 changes: 1 addition & 1 deletion spec/rubocop/cop/generator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def on_send(node)
1. Modify the description of Style/FakeCop in config/default.yml
2. Implement your new cop in the generated file!
3. Commit your new cop with a message such as
e.g. "Add new `Style/FakeCop` cop."
e.g. "Add new `Style/FakeCop` cop"
4. Run `bundle exec rake changelog:new` to generate a changelog entry
for your new cop.
TODO
Expand Down

0 comments on commit 25c95e6

Please sign in to comment.