[Fixes #9487] Mark Naming/MemoizedInstanceVariableName as unsafe

rubocop · Mar 17, 2021 · 255692c · 255692c
1 parent 6746f15
commit 255692c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/changelog/change_mark_namingmemoizedinstancevariablename.md b/changelog/change_mark_namingmemoizedinstancevariablename.md
@@ -0,0 +1 @@
+* [#9487](https://github.com/rubocop/rubocop/issues/9487): Mark Naming/MemoizedInstanceVariableName as unsafe. ([@marcandre][])
diff --git a/config/default.yml b/config/default.yml
@@ -2490,6 +2490,7 @@ Naming/MemoizedInstanceVariableName:
     - disallowed
     - required
     - optional
+  Safe: false
 
 Naming/MethodName:
   Description: 'Use the configured style when naming methods.'

diff --git a/lib/rubocop/cop/naming/memoized_instance_variable_name.rb b/lib/rubocop/cop/naming/memoized_instance_variable_name.rb
@@ -139,6 +139,10 @@ module Naming
       #   define_method(:foo) do
       #     @_foo ||= calculate_expensive_thing
       #   end
+      #
+      # This cop relies on the pattern `@instance_var ||= ...`,
+      # but this is sometimes used for other purposes than memoization
+      # so this cop is considered unsafe.
       class MemoizedInstanceVariableName < Base
         include ConfigurableEnforcedStyle