[Fix #10504] Fix a false positive for Lint/UnusedMethodArgument

Fixes #10504. This PR fixes a false positive for `Lint/UnusedMethodArgument` when using `raise NotImplementedError` with optional arguments.
rubocop · Apr 6, 2022 · 253297e · 253297e
1 parent 7e148bf
commit 253297e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/changelog/fix_a_false_positive_for_lint_unused_method_argument.md b/changelog/fix_a_false_positive_for_lint_unused_method_argument.md
@@ -0,0 +1 @@
+* [#10504](https://github.com/rubocop/rubocop/issues/10504): Fix a false positive for `Lint/UnusedMethodArgument` when using `raise NotImplementedError` with optional arguments. ([@koic][])
diff --git a/lib/rubocop/cop/lint/unused_method_argument.rb b/lib/rubocop/cop/lint/unused_method_argument.rb
@@ -64,7 +64,7 @@ class UnusedMethodArgument < Base
 
         # @!method not_implemented?(node)
         def_node_matcher :not_implemented?, <<~PATTERN
-          {(send nil? :raise (const {nil? cbase} :NotImplementedError))
+          {(send nil? :raise (const {nil? cbase} :NotImplementedError) ...)
            (send nil? :fail ...)}
         PATTERN
 

diff --git a/spec/rubocop/cop/lint/unused_method_argument_spec.rb b/spec/rubocop/cop/lint/unused_method_argument_spec.rb
@@ -466,6 +466,14 @@ def method(arg)
       RUBY
     end
 
+    it 'accepts a method with a single unused parameter & raises NotImplementedError, message' do
+      expect_no_offenses(<<~RUBY)
+        def method(arg)
+          raise NotImplementedError, message
+        end
+      RUBY
+    end
+
     it 'accepts a method with a single unused parameter & raises ::NotImplementedError' do
       expect_no_offenses(<<~RUBY)
         def method(arg)