Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix an incorrect auto-correct for
Style/IfUnlessModifier
This PR fixes the following incorrect auto-correct for `Style/IfUnlessModifier` when using a method with heredoc argument. ```console % cat .rubocop.yml Layout/LineLength: Max: 80 % cat example.rb fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo(<<~EOS) if condition string EOS % bundle exec rubocop --only Style/IfUnlessModifier -a (snip) Inspecting 1 file C Offenses: example.rb:1:70: C: [Corrected] Style/IfUnlessModifier: Modifier form of if makes the line too long. fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo(<<~EOS) if condition ^^ 1 file inspected, 1 offense detected, 1 offense corrected ``` ## Before Auto-corrected to unexpected invalid syntax code. ```console % cat example.rb if condition fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo(<<~EOS) end string EOS % ruby -c example.rb example.rb:2: syntax error, unexpected end-of-input, expecting `end' ``` ## After Auto-corrected to expected valid syntax code. ```console % cat example.rb if condition fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo(<<~EOS) string EOS end ```
- Loading branch information
Showing
3 changed files
with
57 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* [#9690](https://github.com/rubocop/rubocop/pull/9690): Fix an incorrect auto-correct for `Style/IfUnlessModifier` when using a method with heredoc argument. ([@koic][]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters