Merge pull request #8427 from koic/fix_error_for_lint_ineffective_acc…

…ess_modifier

[Fix #8424] Fix an error for `Lint/IneffectiveAccessModifier`

CHANGELOG.md

@@ -31,6 +31,7 @@
 * [#8330](https://github.com/rubocop-hq/rubocop/issues/8330): Fix a false positive for `Style/MissingRespondToMissing` when defined method with inline access modifier. ([@koic][])
 * [#8422](https://github.com/rubocop-hq/rubocop/issues/8422): Fix an error for `Lint/SelfAssignment` when using or-assignment for constant. ([@koic][])
 * [#8423](https://github.com/rubocop-hq/rubocop/issues/8423): Fix an error for `Style/SingleArgumentDig` when without a receiver. ([@koic][])
+* [#8424](https://github.com/rubocop-hq/rubocop/issues/8424): Fix an error for `Lint/IneffectiveAccessModifier` when there is `begin...end` before a method definition. ([@koic][])
 
 ### Changes
 

lib/rubocop/cop/lint/ineffective_access_modifier.rb

@@ -96,9 +96,7 @@ def format_message(modifier)
         end
 
         # rubocop:disable Metrics/CyclomaticComplexity
-        def ineffective_modifier(node, modifier = nil, &block)
-          ignored_methods = nil
-
+        def ineffective_modifier(node, ignored_methods = nil, modifier = nil, &block)
           node.each_child_node do |child|
             case child.type
             when :send

spec/rubocop/cop/lint/ineffective_access_modifier_spec.rb

@@ -118,4 +118,18 @@ def self.method
       RUBY
     end
   end
+
+  context 'when there is `begin` before a method definition' do
+    it 'does not register an offense' do
+      expect_no_offenses(<<~RUBY)
+        class C
+          begin
+          end
+
+          def do_something
+          end
+        end
+      RUBY
+    end
+  end
 end