[Fix #11861] Fix a false positive for Layout/SpaceAfterSemicolon

Fixes #11861. This PR fixes a false positive for `Layout/SpaceAfterSemicolon` when no space between a semicolon and a closing brace of string interpolation.
rubocop · May 9, 2023 · 0bbce1a · 0bbce1a
1 parent b8005a4
commit 0bbce1a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/changelog/fix_a_false_positive_for_layout_space_after_semicolon.md b/changelog/fix_a_false_positive_for_layout_space_after_semicolon.md
@@ -0,0 +1 @@
+* [#11861](https://github.com/rubocop/rubocop/issues/11861): Fix a false positive for `Layout/SpaceAfterSemicolon` when no space between a semicolon and a closing brace of string interpolation. ([@koic][])
diff --git a/lib/rubocop/cop/mixin/space_after_punctuation.rb b/lib/rubocop/cop/mixin/space_after_punctuation.rb
@@ -36,7 +36,7 @@ def space_required_before?(token)
       end
 
       def allowed_type?(token)
-        %i[tRPAREN tRBRACK tPIPE].include?(token.type)
+        %i[tRPAREN tRBRACK tPIPE tSTRING_DEND].include?(token.type)
       end
 
       def space_forbidden_before_rcurly?

diff --git a/spec/rubocop/cop/layout/space_after_semicolon_spec.rb b/spec/rubocop/cop/layout/space_after_semicolon_spec.rb
@@ -24,6 +24,12 @@
       it 'accepts a space between a semicolon and a closing brace' do
         expect_no_offenses('test { ; }')
       end
+
+      it 'accepts no space between a semicolon and a closing brace of string interpolation' do
+        expect_no_offenses(<<~'RUBY')
+          "#{ ;}"
+        RUBY
+      end
     end
 
     context 'when EnforcedStyle for SpaceInsideBlockBraces is space' do