Support csend on Style/SymbolProc

rubocop · Jul 13, 2022 · 0217a37 · 0217a37
1 parent 9808e96
commit 0217a37
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/changelog/change_support_csend_on_stylesymbolproc.md b/changelog/change_support_csend_on_stylesymbolproc.md
@@ -0,0 +1 @@
+* [#10810](https://github.com/rubocop/rubocop/pull/10810): Support `csend` on `Style/SymbolProc`. ([@r7kamura][])
diff --git a/lib/rubocop/cop/style/symbol_proc.rb b/lib/rubocop/cop/style/symbol_proc.rb
@@ -89,7 +89,7 @@ class SymbolProc < Base
         def_node_matcher :proc_node?, '(send (const {nil? cbase} :Proc) :new)'
 
         # @!method symbol_proc_receiver?(node)
-        def_node_matcher :symbol_proc_receiver?, '{(send ...) (super ...) zsuper}'
+        def_node_matcher :symbol_proc_receiver?, '{({csend | send} ...) (super ...) zsuper}'
 
         # @!method symbol_proc?(node)
         def_node_matcher :symbol_proc?, <<~PATTERN

diff --git a/spec/rubocop/cop/style/symbol_proc_spec.rb b/spec/rubocop/cop/style/symbol_proc_spec.rb
@@ -12,6 +12,17 @@
     RUBY
   end
 
+  it 'registers an offense for csend' do
+    expect_offense(<<~RUBY)
+      coll&.map { |e| e.upcase }
+                ^^^^^^^^^^^^^^^^ Pass `&:upcase` as an argument to `map` instead of a block.
+    RUBY
+
+    expect_correction(<<~RUBY)
+      coll&.map(&:upcase)
+    RUBY
+  end
+
   it 'registers an offense for a block when method in body is unary -/+' do
     expect_offense(<<~RUBY)
       something.map { |x| -x }