Fix an error for Ambiguous cop name RSpec/Rails/HttpStatus
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
changed the title
RSpec/Rails/HttpStatus
Fix: #18 This PR fixes an error for Ambiguous cop name `RSpec/Rails/HttpStatus` in the `rubocop-rspec_rails` gem.
ydah
commented
Apr 11, 2024
| @@ -21,7 +21,7 @@ | |||
| # https://github.com/rubocop/rubocop-rspec_rails/issues/8 | |||
| module RuboCop | |||
| module Cop | |||
| class AmbiguousCopName # rubocop:disable Style/Documentation | |||
| class Registry # rubocop:disable Style/Documentation | |||
There was a problem hiding this comment.
Wrong class to override... 🙇
https://github.com/rubocop/rubocop/blob/2e46ac20ed3efb7f2b9ea1168b148034f11e1e46/lib/rubocop/cop/registry.rb#L3-L19
There was a problem hiding this comment.
By the way, it’s not necessary to reopen the class to prepend a module. E.g. RuboCop::Cop::Registry.prepend(Module.new… would work fine.
|
@mjankowski @pirj This should fix it. |
bquorning
approved these changes
Apr 11, 2024
| @@ -21,7 +21,7 @@ | |||
| # https://github.com/rubocop/rubocop-rspec_rails/issues/8 | |||
| module RuboCop | |||
| module Cop | |||
| class AmbiguousCopName # rubocop:disable Style/Documentation | |||
| class Registry # rubocop:disable Style/Documentation | |||
There was a problem hiding this comment.
By the way, it’s not necessary to reopen the class to prepend a module. E.g. RuboCop::Cop::Registry.prepend(Module.new… would work fine.
|
Nice! Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #18
This PR fixes an error for Ambiguous cop name
RSpec/Rails/HttpStatusin therubocop-rspec_railsgem.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).