Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of great changes just sitting on the master branch waiting for a release. And 4 new contributors!
Not to diminish any of the contributions, but the reason I want to create a release now (and I should have done it weeks ago) is that it will be explicitly incompatible with RuboCop 1.0. I hope that as many as possible of our users will upgrade to 1.43.0, so that the will be (temporarily) blocked from upgrading when RuboCop 1.0 is released.
Please note that I am adding
VersionAdded: '1.43'
forRSpec/MultipleMemoizedHelpers
which seemed to be missing.Also I think our documentation isn’t being updated correctly at the moment, and we should fix that ASAP. But again, I wanted to get this release out ASAP too :-)
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).