Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cops by using TopLevelGroup #977

Merged
merged 7 commits into from Aug 4, 2020
Merged

Improve cops by using TopLevelGroup #977

merged 7 commits into from Aug 4, 2020

Commits on Aug 3, 2020

  1. Fix misleading spec 

    Example groups were not nested enough to demonstrate the offence.
Describing inside a module and a class is actually quite legitimate, but
the limit for nested example groups still applies.
    @pirj
    pirj committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    4070d70 View commit details
    Browse the repository at this point in the history

  2. Detect all kinds of example groups in NestedGroups 

    TopLevelDescribe was only able to detect top-level `describe`.

TopLevelGroup had a deficiency of missing top-level example groups
wrapped in module and class namespaces.
    @pirj
    pirj committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    330929f View commit details
    Browse the repository at this point in the history

  3. Detect all kinds of example groups in FilePath cop

    @pirj
    pirj committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    5f46a62 View commit details
    Browse the repository at this point in the history

  4. Refactor DescribeMethod to use TopLevelGroup

    @pirj
    pirj committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    df0ea6e View commit details
    Browse the repository at this point in the history

  5. Detect all kinds of example groups in MultipleDescribes 

    Also, shared groups now
    @pirj
    pirj committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    6276370 View commit details
    Browse the repository at this point in the history

  6. Refactor DescribeClass to use TopLevelGroup

    @pirj
    pirj committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    5f715e3 View commit details
    Browse the repository at this point in the history

  7. Remove redundant require

    @pirj
    pirj committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    130e720 View commit details
    Browse the repository at this point in the history