Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mistake in RSpec/PredicateMatcher doc #937

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Fix mistake in RSpec/PredicateMatcher doc #937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rubocop/cop/rspec/predicate_matcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,12 @@ def replacement_matcher(node)
# expect(foo).to be_something
pirj marked this conversation as resolved.
Show resolved Hide resolved
#
# # also good - It checks "true" strictly.
# expect(foo).to be(true)
# expect(foo.something?).to be(true)
#
# @example Strict: false, EnforcedStyle: inflected
# # bad
# expect(foo.something?).to be_truthy
# expect(foo).to be(true)
# expect(foo.something?).to be(true)
#
# # good
# expect(foo).to be_something
Expand Down
4 changes: 2 additions & 2 deletions manual/cops_rspec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2452,14 +2452,14 @@ expect(foo.something?).to be_truthy
expect(foo).to be_something

# also good - It checks "true" strictly.
expect(foo).to be(true)
expect(foo.something?).to be(true)
```
#### Strict: false, EnforcedStyle: inflected

```ruby
# bad
expect(foo.something?).to be_truthy
expect(foo).to be(true)
expect(foo.something?).to be(true)

# good
expect(foo).to be_something
Expand Down