RSpec/SubjectStub. Add top level group callback #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
force-pushed
the
add-top-level-group-callback
branch
from
cad26f6
to
7a0a6b6
Compare
pirj
reviewed
Jun 12, 2020
andrykonchin
commented
Jun 12, 2020
|
@pirj Fixed all the issues |
pirj
approved these changes
Jun 13, 2020
lib/rubocop/rspec/top_level_group.rb
Outdated
| end | ||
|
|
||
| def top_level_nodes | ||
| @top_level_nodes ||= |
There was a problem hiding this comment.
Minor: does it make sense to memoize it? It's only called once from a method that is also memoized.
Darhazer
approved these changes
Jun 14, 2020
| top_level_nodes.select { |n| example_or_shared_group?(n) } | ||
| end | ||
|
|
||
| def top_level_nodes |
There was a problem hiding this comment.
At some point, we may want to DRY this between the different modules.
Also, top_level_describe seems to be a special case on top_level_group.
For now I'm fine with keeping it as it is
|
Merging without consensus, since this change has been discussed in the past, and only affects one cop. Thank you again, @andrykonchin ! |
pirj
added a commit
that referenced
this pull request
Jul 23, 2020
Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977
pirj
reviewed
Jul 23, 2020
| (ExampleGroups::ALL + SharedGroups::ALL).block_pattern | ||
|
|
||
| def on_block(node) | ||
| return unless respond_to?(:on_top_level_group) |
There was a problem hiding this comment.
An afterthought.
I understand that this guard statement is on the very top to avoid a quite expensive check done in top_level_group?.
But is it really necessary? If a cop includes TopLevelGroup, that means it defines a on_top_level_group method? Otherwise why would it include TopLevelGroup?
Or am I missing something?
There was a problem hiding this comment.
TBH I just copied this approach from TopLevelDescribe module. I don't see any benefit in having such condition here.
6 tasks
pirj
added a commit
that referenced
this pull request
Oct 22, 2020
Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977
pirj
added a commit
that referenced
this pull request
Oct 22, 2020
Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977
pirj
added a commit
that referenced
this pull request
Oct 22, 2020
Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977
pirj
added a commit
that referenced
this pull request
Nov 2, 2020
Why? - it was slow #925 (comment) - it ignored non-describe top-level example groups #925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - #932 - #977
pirj
added a commit
to rubocop/rubocop-capybara
that referenced
this pull request
Dec 29, 2022
Why? - it was slow rubocop/rubocop-rspec#925 (comment) - it ignored non-describe top-level example groups rubocop/rubocop-rspec#925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - rubocop/rubocop-rspec#932 - rubocop/rubocop-rspec#977
ydah
pushed a commit
to rubocop/rubocop-factory_bot
that referenced
this pull request
Apr 13, 2023
Why? - it was slow rubocop/rubocop-rspec#925 (comment) - it ignored non-describe top-level example groups rubocop/rubocop-rspec#925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - rubocop/rubocop-rspec#932 - rubocop/rubocop-rspec#977
ydah
pushed a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
Why? - it was slow rubocop/rubocop-rspec#925 (comment) - it ignored non-describe top-level example groups rubocop/rubocop-rspec#925 (comment) `TopLevelGroup` is a modern replacement for `TopLevelDescribe`. Examples how to migrate cops from TopLevelDescribe to TopLevelGroup: - rubocop/rubocop-rspec#932 - rubocop/rubocop-rspec#977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a followup of #925 and it addresses the following issue #925 (comment)
Changes:
The goal of TopLevelGroup is to handle all the possible example and shared groups in a spec file. It calls
on_top_level_groupcallback for every top-leveldescribe,context,feature,shared context... group.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).