Use node pattern generic parameters to simplify a cop #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pirj
commented
Jul 1, 2020
pirj
commented
Jul 1, 2020
|
RuboCop 0.8.7 we're currently depend on depends on |
pirj
force-pushed
the
poc-generic-node-pattern-param-usage
branch
from
c68c75c
to
08b5f46
Compare
pirj
changed the title
pirj
commented
Jul 15, 2020
| end | ||
|
|
||
| def find_aggregate_failures(example_node) | ||
| example_node.send_node.each_ancestor(:block) | ||
| .find { |block_node| aggregate_failures_present?(block_node) } | ||
| .find { |block_node| aggregate_failures?(block_node, ANYTHING) } |
There was a problem hiding this comment.
A new addition to rubocop-ast made it possible to pass in true and _-alike's.
That was it became possible to collapse two node matchers into one, since they only had that distinction.
One is used to match:
describe aggregate_examples: true do
# or
describe :aggregate_examples dothe other any of:
describe aggregate_examples: false do
# or
describe aggregate_examples: true do
# or
describe :aggregate_examples do
pirj
force-pushed
the
poc-generic-node-pattern-param-usage
branch
from
08b5f46
to
1a47e9e
Compare
|
Green. |
Darhazer
approved these changes
Jul 15, 2020
pirj
force-pushed
the
poc-generic-node-pattern-param-usage
branch
from
4afd467
to
4a6f646
Compare
#804 (comment) Support introduced in rubocop/rubocop-ast#31 Presumably this will land in RuboCop 1.0 or 1.0.1 worst case.
pirj
force-pushed
the
poc-generic-node-pattern-param-usage
branch
from
4a6f646
to
3b41df3
Compare
bquorning
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#804 (comment)
Support introduced in rubocop/rubocop-ast#31
Presumably generic parameters support will land in RuboCop 1.0 or 1.0.1 worst case.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).