Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSpec/SubjectStub. Refactor and decrease complexity #925

Merged
merged 6 commits into from Jun 11, 2020
Merged

RSpec/SubjectStub. Refactor and decrease complexity #925

merged 6 commits into from Jun 11, 2020

Commits on Jun 7, 2020

  1. RSpec/SubjectStub. Refactor and decrease complexity

    @andrykonchin
    andrykonchin committed Jun 7, 2020
    Copy the full SHA
    20e37fb View commit details
    Browse the repository at this point in the history

  2. RSpec/SubjectStub. Code review. Refactor #find_all_named_subjects method

    @andrykonchin
    andrykonchin committed Jun 7, 2020
    Copy the full SHA
    817a77e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. RSpec/SubjectStub. Code review. Handle case with several explicit sub… 

    …jects in example group
    @andrykonchin
    andrykonchin committed Jun 8, 2020
    Copy the full SHA
    7e76bd7 View commit details
    Browse the repository at this point in the history

  2. RSpec/SubjectStub. Code review. Use #on_top_level_describe instead of… 

    … #on_block callback
    @andrykonchin
    andrykonchin committed Jun 8, 2020
    Copy the full SHA
    341ae44 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Revert "RSpec/SubjectStub. Code review. Use #on_top_level_describe in… 

    …stead of #on_block callback"

This reverts commit 341ae44.
    @andrykonchin
    andrykonchin committed Jun 9, 2020
    Copy the full SHA
    358d129 View commit details
    Browse the repository at this point in the history

  2. RSpec/SubjectStub. Code review. Remove excessive condition and fix se… 

    …arching of outer example group
    @andrykonchin
    andrykonchin committed Jun 9, 2020
    Copy the full SHA
    956efea View commit details
    Browse the repository at this point in the history