Fix RuboCop builds #902
Closed
Fix RuboCop builds #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuboCop has updated its lowest supported Ruby version syntax to 2.4 in version 0.82, and our builds pick the most recent release on CI, and this was failing all RuboCop checks.
Gemspec/RequiredRubyVersion: required_ruby_version (2.3, declared in rubocop-rspec.gemspec) and TargetRubyVersion (2.4, which may be specified in .rubocop.yml) should be equal. No, it shouldn't be equal. We're an extension that has support for earlier RuboCop versions and thus earlier Ruby versions.
|
Great minds think alike: I opened #901 just 15 minutes ago :-) |
|
I was triggered by a failure in #899 XD and tried to ignore red |
|
Closing in favour of #901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump TargetRubyVersion to 2.4 as latest RuboCop version, 0.82, dropped support for 2.3 in TargetRubyVersion.
RuboCop has updated its lowest supported Ruby version syntax to 2.4 in version 0.82, and our builds pick the most recent release on CI, and this was failing all RuboCop checks.
No, it shouldn't be equal. We're an extension that has support for earlier RuboCop versions and thus earlier Ruby versions.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).