Rename Rails department to RSpecRails

[ixti]

Rubocop provides Rails/HttpStatus cop to lint render (and its friends) methods in controllers. That causes conflicts with RSpec/Rails/HttpStatus and makes one of them dysfunctional depending on require order.

This patchset renames RuboCop::Cop::RSpec::Rails::HttpStatus to RuboCop::Cop::RSpec::RSpecRails::HttpStatus, which both resolves namespacing conflict and makes department name better match with gem it aims to (rspec-rails).

---

Resolves: #611

[pirj]

Looks good to me.
Thanks a lot!

[ixti]

@bquorning any chance to get this merged? :D

[bquorning]

I’m split on this one. It seems like a fix of the symptoms instead of a fix of the underlying problem. RuboCop::Cop::RSpec::Rails::HttpStatus and RuboCop::Cop::Rails::HttpStatus are two different namespaces, so it should be possible to make it work.

@Darhazer and @dgollahon, do you have any input on this?

[ixti]

I agree that these are two different namespaces. And I had proposal of overriding default cop badge:
#611 (comment) as for what it worth I'm fine with either way. It's just right now either rails cop won't work or rspec cop won't, and it's a bummer.

[ixti]

Is there still interest in fixing this cop? Right now it causes a lot of frustration: depending on the order of requires either one cop will be working or the other...

[dgollahon]

I’m split on this one. It seems like a fix of the symptoms instead of a fix of the underlying problem. RuboCop::Cop::RSpec::Rails::HttpStatus and RuboCop::Cop::Rails::HttpStatus are two different namespaces, so it should be possible to make it work.

@Darhazer and @dgollahon, do you have any input on this?

It seems like the ideal approach would be to fix the way departments/plugins are handled (presumably in rubocop) proper, but I doubt that will get resolved in a timely manner unless @ixti wants to pursue that further. The rename seems sensible in the short-term to me, except that renaming the cop will be disruptive to existing users. That said, it would be the same disruption if we supported sub-departments in the cop name because the config would still have to be updated.

I defer to @bquorning / @Darhazer, but this strikes me as reasonable for now.

[pirj]

After giving it another thought I tend to side with you guys, it needs to be fixed on RuboCop side.
@bbatsov I could only find rubocop/rubocop#5251, should we file another ticket to track this problem?

[bbatsov]

@pirj Yeah, probably we should.