Improve Focus cop #777
Merged
Improve Focus cop #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darhazer
reviewed
Jun 18, 2019
3 tasks
|
@bquorning @Darhazer Is there anything apart from the missing changelong entry that needs to be addressed here? I believe this may be released together with #804 that bumps RuboCop to the version that provides children matching. |
Darhazer
approved these changes
Aug 18, 2019
bquorning
approved these changes
Aug 18, 2019
- Due to the order of how the patterns were defined, the hash capture took priority over the broader capture pattern. I've changed the matching logic to be directly represented by the any-order matcher patterns which also simplifies the code, if just slightly. - Closes #775
- Pending examples are also capable of being focused so I've added them to the examples that are searched for.
bquorning
force-pushed
the
improve-focus-cop
branch
from
43021ea
to
9811446
Compare
|
Added 1 Changelog commit. Rebased on master (and force-pushed) so we can merge without conflicts. |
|
@Darhazer @pirj @dgollahon Could one of you please double check that this PR is ready to merge? I’ll rebase #824 afterwards. |
Darhazer
approved these changes
Sep 27, 2019
|
Thanks @bquorning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Focus cop in a couple of ways.
pendingto the examples that it can detect (since these can be focused).fit. #398 as well but it's actually much trickier than it might first appear.Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).