Compatibility with RuboCop v0.60.0 #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
commented
Oct 28, 2018
manual/cops_rails.md
Outdated
| @@ -41,6 +41,7 @@ it { is_expected.to have_http_status :error } | |||
|
|
|||
| Name | Default value | Configurable values | |||
| --- | --- | --- | |||
| VersionAdded | `0.54` | Float | |||
Merged
|
The point number |
|
Probably also related to rubocop/rubocop#5251 and rubocop/rubocop#3414. |
Darhazer
referenced
this pull request
Nov 1, 2018
I disagree with the recent changes in AlignHash, so a combination of `key` and `table` styles is no longer allowed. The issue is very well described in rubocop/rubocop#6410 .
bquorning
force-pushed
the
rubocop-0.60.0
branch
from
90d55ed
to
cb4984f
Compare
|
@Darhazer Fixed and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few interesting changes between RuboCop v0.59.2 and v0.60.0:
[:exclude_limit]when checkingcop.config_to_allow_offenses.keyandtablestyles is no longer allowed. I disagree with this decision, and have voiced my opinion on the issue Feature request: Layout/AlignHash option to allow forkeyandtablestyles to both be permissible rubocop#6410Rails/HttpStatusandRSpec/Rails/HttpStatus… again. @Darhazer would you take a look at my last commit “tmp”?Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).