Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some rubocop offenses #1873

Merged
merged 1 commit into from Apr 25, 2024
Merged

Fix some rubocop offenses #1873

merged 1 commit into from Apr 25, 2024

Conversation

ydah
Copy link
Member

@ydah ydah commented Apr 25, 2024

spec/rubocop/cop/rspec/repeated_example_group_description_spec.rb:93:6: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
  it 'register offense for different example group with similar descriptions' do
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/rubocop/cop/rspec/repeated_example_group_description_spec.rb:93:81: C: Layout/LineLength: Line is too long. [81/80]
  it 'registers offense for different example group with similar descriptions' do
                                                                                ^
spec/rubocop/cop/rspec/repeated_example_group_description_spec.rb:201:6: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
  it 'register offense if same method used in docstring' do
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

```
spec/rubocop/cop/rspec/repeated_example_group_description_spec.rb:93:6: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
  it 'register offense for different example group with similar descriptions' do
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/rubocop/cop/rspec/repeated_example_group_description_spec.rb:93:81: C: Layout/LineLength: Line is too long. [81/80]
  it 'registers offense for different example group with similar descriptions' do
                                                                                ^
spec/rubocop/cop/rspec/repeated_example_group_description_spec.rb:201:6: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
  it 'register offense if same method used in docstring' do
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
@ydah ydah requested a review from a team as a code owner April 25, 2024 06:51
@ydah ydah merged commit 0a7a442 into master Apr 25, 2024
24 checks passed
@ydah ydah deleted the rubocop-offenses branch April 25, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants