Improve release workflow #1869
Merged
Improve release workflow #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydah
force-pushed
the
improve-release
branch
2 times, most recently
from
62761b9
to
16c3fdd
Compare
bquorning
reviewed
Apr 9, 2024
bquorning
approved these changes
Apr 9, 2024
|
@bquorning I don't have permission, so please check if the following settings are checked ON. |
|
Yep, the setting is ON. |
This was referenced Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the release workflow.
It turns out that being able to push directly to the default branch is quite difficult. That's because if GitHub actions can push to a protected branch, all you have to do is code a workflow that creates a branch and pushes it to other branches, and any collaborator in the repository can push whatever code they want to any branch.
https://github.com/orgs/community/discussions/25305#discussioncomment-3247401
That last one step might be a pain, but I think it's better to automate it to the point where you create a PR that switches back versions.
After the release workflow, a PR is created that switches back, so we should just merge it.
Note that this requires the following settings to be checked on:
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).