New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extracted cops in Capybara
, FactoryBot
and Rails
departments.
#1848
Conversation
Capybara
, FactoryBot
, Rails
)Capybara
, FactoryBot
and Rails
departments.
VersionAdded: '1.18' | ||
VersionChanged: '2.0' | ||
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/CurrentPathExpectation | ||
|
||
RSpec/Capybara/FeatureMethods: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea @pirj. I’ve added this as an issue in the 3.0 milestone.
@ydah Now that we have a separate |
I updated this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼
It is also a blocker for subsequent PR, so this PR will be merged. We can also follow up. |
This PR remove extracted cop departments. (
Capybara
,FactoryBot
,Rails
)Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).