Make RSpec/MatchArray and RSpec/ContainExactly pending
#1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😱 I thought we had a CI check to catch this. |
bquorning
reviewed
Apr 5, 2023
ydah
force-pushed
the
to_pending
branch
2 times, most recently
from
c1a1e4c
to
a818c3d
Compare
Fix: rubocop#1612 This PR is make `RSpec/MatchArray` and `RSpec/ContainExactly` pending.
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
13 tasks
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
3 tasks
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Apr 6, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
bquorning
approved these changes
Apr 6, 2023
ydah
added a commit
to ydah/rubocop-rspec
that referenced
this pull request
Jul 7, 2023
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop#1613 (comment)
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop/rubocop-rspec#1613 (comment)
ydah
added a commit
to rubocop/rubocop-rspec_rails
that referenced
this pull request
Mar 27, 2024
…me `Enabled: true` I suggest adding checks with Danger as a preventive measure against recurrence. Resolve: rubocop/rubocop-rspec#1613 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1612
This PR is make
RSpec/MatchArrayandRSpec/ContainExactlypending.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).