Extract Factory Bot cops

[ydah]

#1440

TODO

• once the gem is published, remove the temp commit that adds rubocop-factory_bot to Gemfile
• set the version constraint in gemspec for rspec-factory_bot
• Creating a Repository for https://github.com/rubocop/rubocop-factory_bot
• Extracted to https://github.com/rubocop/rubocop-factory_bot

All green ✅

Here's where to temporary extract it:.

• Extract Factory Bot cops ydah/rubocop-factory_bot#1

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• [-] Added tests.
• [-] Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

Looks great, thank you!
Just a few notes.

[ydah]

@bquorning @Darhazer We would be happy if you could check here when you have time.

[pirj]

Thank you so much!

[ydah]

The following changes to the FactoryBot department have been incorporated

• Fix a false positive for RSpec/FactoryBot/ConsistentParenthesesStyle inside &&, || and :? when omit_parentheses is on #1601

[ydah]

If you are authorized to create the following repositories, could you please create the following repositories?
https://github.com/rubocop/rubocop-factory_bot

[bquorning]

https://github.com/rubocop/rubocop-factory_bot has been created, and you should have received an email about getting access (as admin). I have given write permissions to the @rubocop/rubocop-rspec team too.

[ydah]

The following PRs have been created and are being extracted.

• Extract RuboCop FactoryBot from RuboCop RSpec rubocop-factory_bot#1

[pirj]

Thank you!

[bquorning]

@ydah Would you rebase on top of e.g. the release branch, and fix the last todo item? Then I will get this PR merged and v2.22.0 released.

[bquorning]

@ydah Feel free to also run bundle exec rake cut_release:minor and add the changes to this PR.

[ydah]

@bquorning Sorry for the late reply. I have updated this PR and ready for release ✅

[ydah]

@bquorning @pirj @Darhazer
BTW, could you please invite me to join the rubocop-rspec team?
I can transfer issues between rubocop-rspec, rubocop_capybara and rubocop-factory_bot, which will make maintenance easier. So I hope you will consider this 🙏

[bquorning]

BTW, could you please invite me to join the rubocop-rspec team?

Certain, and it’s about time 😅 An invitation has been sent.

[bquorning]

@pirj @ydah Is this ready for merge + release?

[ydah]

Thank you for the invitation to join the rubocop-rspec team!
Yes. Ready for release👍

[pirj]

Looks ready! 🙌

[bquorning]

And it’s official: https://rubygems.org/gems/rubocop-rspec/versions/2.22.0

Thank you @ydah 🎉