Patch release (v2.17.1) #1559
Merged
Patch release (v2.17.1) #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edicateMatcher Fix an incorrect autocorrect for `RSpec/PredicateMatcher` when multiline expect and predicate method with heredoc
…Matcher Fix a false positive for `RSpec/PredicateMatcher` when multiple arguments and not replaceable method
|
Nits: The branch name % git checkout v2.17.0
% git checkout -b 2-17-stable
% git cherry-pick 3799e63e1fb5941e4f6a72f0f6d03be4aa5d2c37 # https://github.com/rubocop/rubocop-rspec/pull/1555
% git cherry-pick 5113d6f96ad536979710b361e3d6c101daa84da6 # https://github.com/rubocop/rubocop-rspec/pull/1554
% # Commit "Patch release (v2.17.1)"
% # ReleaseThis branching strategy is used in rails/rails and ruby/ruby repos. |
|
Our release timeline is linear, unlike Ruby or Rails'. We don't intend to make any further 2.17.x releases after 2.18 is released. With that in mind, 2.17-stable seems unnecessary. |
|
Yes, |
|
I get it! Thank you for the explanation and the bug fix release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing v2.17.1 with the recent patches by @ydah but without #1519 from @pirj (which will be released as v2.18.0 soon after).
The v2.17.1 release will be cut from commit f510f1a.