Fix an incorrect autocorrect for RSpec/PredicateMatcher when multiline expect and predicate method with heredoc
#1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
approved these changes
Jan 14, 2023
ydah
force-pushed
the
fix-incorrect-autocorrect-rspec-PredicateMatcher
branch
from
eb88035
to
d51a350
Compare
pirj
reviewed
Jan 14, 2023
ydah
force-pushed
the
fix-incorrect-autocorrect-rspec-PredicateMatcher
branch
from
d51a350
to
c5414b2
Compare
5 tasks
Darhazer
reviewed
Jan 14, 2023
| corrector_explicit(corrector, node, actual, matcher, matcher) | ||
| end | ||
| end | ||
| end | ||
|
|
||
| def uncorrectable_matcher?(node, matcher) | ||
| str_args = matcher.arguments.select(&:str_type?) | ||
| str_args.any?(&:heredoc?) && !same_line?(node, matcher) |
There was a problem hiding this comment.
what if the heredoc contains variables? wouldn't it be dstr_type and still contain heredoc nodes? I suggest adding dstr and xstr here
There was a problem hiding this comment.
Thank you for catching this. I updated this PR.
…ine expect and predicate method with heredoc
This PR is fix an incorrect autocorrect for `RSpec/PredicateMatcher` when multiline expect and predicate method with heredoc.
The following code:
```ruby
expect(foo)
.to be_something(<<~TEXT)
bar
TEXT
```
This would be corrected as follows:
```ruby
expect(foo.something?(<<~TEXT))
.to be(true)
bar
TEXT
```
ydah
force-pushed
the
fix-incorrect-autocorrect-rspec-PredicateMatcher
branch
from
c5414b2
to
3799e63
Compare
|
@Darhazer Is this PR ok to merge? |
Darhazer
approved these changes
Jan 15, 2023
bquorning
added a commit
that referenced
this pull request
Jan 16, 2023
…edicateMatcher Fix an incorrect autocorrect for `RSpec/PredicateMatcher` when multiline expect and predicate method with heredoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fix an incorrect autocorrect for
RSpec/PredicateMatcherwhen multiline expect and predicate method with heredoc.The following code:
This would be corrected as follows:
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).