Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum RuboCop dependency to fix DSL configuration merging #1181

Merged
merged 1 commit into from Aug 12, 2021
Merged

Bump minimum RuboCop dependency to fix DSL configuration merging #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -8,6 +8,7 @@
* Add `RSpec/ExcessiveDocstringSpacing` cop. ([@G-Rath][])
* Add `RSpec/SubjectDeclaration` cop. ([@dswij][])
* Fix excessive whitespace removal in `RSpec/EmptyHook' autocorrection. ([@pirj][])
* Bump RuboCop requirement to v1.19.0. ([@pirj][])

## 2.4.0 (2021-06-09)

Expand Down
3 changes: 1 addition & 2 deletions rubocop-rspec.gemspec
View file
Open in desktop
Expand Up @@ -36,8 +36,7 @@ Gem::Specification.new do |spec|
'documentation_uri' => 'https://docs.rubocop.org/rubocop-rspec/'
}

spec.add_runtime_dependency 'rubocop', '~> 1.0'
spec.add_runtime_dependency 'rubocop-ast', '>= 1.1.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RuboCop 1.19.0 depends on rubocop-ast >= 1.9.1, < 2.0, so this line is redundant.

spec.add_runtime_dependency 'rubocop', '~> 1.19'

spec.add_development_dependency 'rack'
spec.add_development_dependency 'rake'
Expand Down