Fix default config for sub-departments

[pirj]

It turns out that the default config does not apply for sub-departments.
It is weird on many levels:

• RSpec DSL configuration didn't work
• • RSpec DSL doesn't work as intended anyway RSpec/Language isn't merging properly #1126
• if users would re-define RSpec DSL, they would have to do it for all sub-departments, as YAML defaults are only for the default config
• if users would re-define RSpec DSL and use YAML defaults, too, the merging of the resulting config is undetermined

Still, I believe having Include to work correctly is the most important.

fixes #1160

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• [-] Added tests.
• [-] Updated documentation.
• Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

@ShockwaveNN can you please check that this fix solves your case?

# Gemfile
gem 'rubocop-rspec', github: 'rubocop/rubocop-rspec', branch: 'fix-config-for-nested-departments'

[pirj]

@jonas054 Looks good?

[ShockwaveNN]

@pirj Can confirm, this do not broke my minitests

[jonas054]

Looks good as far as I can tell. 👍

[pirj]

Bump

[Darhazer]

I don't really understand the changes 🤷‍♂️ Please rebase anyway :)

[pirj]

@Darhazer Rebased 👍

The explanation of the problem is in #1160 (comment)

configuration for the RSpec department isn't automatically inherited down to subdepartments like RSpec/Rails. I'm not sure if we could change RuboCop so that kind of inheritance takes place. The other solution would be to add

RSpec/Rails:
  Include:
    - "**/*_spec.rb"
    - "**/spec/**/*"

in config/default.yml of rubocop-rspec.

[Darhazer]

It seems that this could be named, e.g. alphanumeric. Might make the file less scary, if it has proper names :)

[pirj]

I vaguely recall I planned to do so (to mimic the well-known &default from config/database.yml 😄), but ended up with numbers somehow. Fixed 👍

[pirj]

Ah, now I recall. It's bin/build_config that does that:

--- a/config/default.yml
+++ b/config/default.yml
@@ -1,10 +1,10 @@
 ---
 RSpec:
   Enabled: true
-  Include: &include
+  Include: &1
     - "**/*_spec.rb"
     - "**/spec/**/*"
-  Language: &language
+  Language: &2
     inherit_mode:
       merge:
         - Expectations

Supposedly, YAML.dump(unified_config) has no respect for named anchors.

I'll revert, otherwise CI is red.

[Darhazer]

so those are not really cops, but departments declarations. Nice

[pirj]

Most of them are cops, but some are departments. It's because cops partially comes from config.keys. And we've included departments separately to config now.