Imrpove performance by limitting on_send calls #1117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Rubocop, since v0.90, has an optimization for not calling on_send based on the expected method_name for the cop.
I applied that to the cops for it was easy (which is about 50% of the cops). Due to the configurable language, it might be hard to do for some cops, and for others, it just requires more refactoring, as the cops check for a method somewhere down the chain.
I haven't really measured the performance improvement, but a naive test (running it with
time
over our own specs) shows a significant difference.cc: @fatkodima
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).Added tests.Updated documentation.CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).