Add clearer examples for SubjectStub cop

[cesc1989]

This PR updates the examples present in the SubjectStub documentation. Previous one was a good indication of when the cop would fire but didn't suggested a way to handle it.

The code examples were taken from the RSpec Style Guide. This gave me reasons to open the PR as they're already accepted ones.

---

Before submitting the PR make sure the following are checked:

• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• [-] Added tests.
• Updated documentation.
• [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
• The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

[pirj]

Thanks! I think it looks better and more aligned with https://rspec.rubystyle.guide/#dont-stub-subject

The document that you've edited is actually automatically generated from code documentation, you were looking to fix this instead and then run rake generate_cops_documentation or just rake.

While you are at it, do you think it makes sense to change the StyleGuide link of the cop to point to the community style guide?

[cesc1989]

Thanks! I think it looks better and more aligned with https://rspec.rubystyle.guide/#dont-stub-subject

The document that you've edited is actually automatically generated from code documentation, you were looking to fix this instead and then run rake generate_cops_documentation or just rake.

While you are at it, do you think it makes sense to change the StyleGuide link of the cop to point to the community style guide?

Hi thanks!

I noticed the failed Circle CI run and realized of that! 😅 . Already working on the right file.

[pirj]

Looks good. Yamllint has stuck.
Please squash your commits.

[cesc1989]

Looks good. Yamllint has stuck.
Please squash your commits.

Squashed

[pirj]

Thanks, @cesc1989 ! 🙌