Quotes #1095
Merged
Quotes #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Nov 14, 2020
| "enabled, then records created in `#{hook}` are not automatically rolled "\ | ||
| "Beware of using `#{hook}` as it may cause state to leak between tests. " \ | ||
| 'If you are using `rspec-rails`, and `use_transactional_fixtures` is ' \ | ||
| "enabled, then records created in `#{hook}` are not automatically rolled " \ |
There was a problem hiding this comment.
Interleaved use of " ' " ' looks a bit confusing.
There was a problem hiding this comment.
Suggestion no. 3 on rubocop/rubocop#6420 😅
I have suggested some rules for consistent formatting of these strings in rubocop/rubocop#6420, but it seems to be too complicated to have RuboCop enforce them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a bit of consistency re. backslashes in and around quotes. I have suggested some rules for consistent formatting of these strings in rubocop/rubocop#6420, but it seems to be too complicated to have RuboCop enforce them.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).