Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0-pre, compatible with RuboCop v1.0 #1054

Merged
merged 1 commit into from Oct 22, 2020
Merged

Conversation

bquorning
Copy link
Collaborator

As discussed in #1051 (comment), let’s make a 2.0 pre-release so our users can try out the new RuboCop v1.0.

I will hold off on pushing our documentation until we release the real v2.0. Does that sound ok?


Before submitting the PR make sure the following are checked:

  • [-] Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Merge at will 👍

@bquorning bquorning merged commit 28d7d9c into release-2.0 Oct 22, 2020
@bquorning bquorning deleted the release branch October 22, 2020 17:19
@pirj
Copy link
Member

pirj commented Oct 22, 2020

Oh. I never thought that no additional fixes will be needed.

ci/circleci: edge-rubocop Your tests passed on CircleCI!

🎉 🙌

@bquorning
Copy link
Collaborator Author

The additional fixes were added to #1019 yesterday :-)

@bquorning
Copy link
Collaborator Author

bquorning commented Oct 22, 2020

Wow, this feature of RubyGems caught me by surprise:

❯ ruby -e 'puts Gem::Version.create("2.0.0-pre")'
2.0.0.pre.pre

and

❯ bundle exec rake -T release
rake release[remote]  # Create tag v2.0.0.pre.pre and build and push rubocop-rspec-2.0.0.pre.pre.gem to rubygems.org

I’ve tracked down this behaviour to https://github.com/rubygems/rubygems/blob/3e71d3fcc22a354d5e698642497dabf77ce6c177/lib/rubygems/version.rb#L208-L222. I cannot see how @version = version.to_s.strip.gsub("-",".pre.") can work together with SemVer’s rules:

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. (my emphasis) (source)

@bquorning
Copy link
Collaborator Author

It’s released as 2.0.0.pre

@pirj
Copy link
Member

pirj commented Oct 22, 2020

rubocop-rspec-2.0.0.pre.pre.gem
Ouch :D

@bquorning bquorning added this to the 2.0 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants