RuboCop 1.0 is supported

[marcandre]

A quick release would be appreciated, as I believe nobody can use rubocop-rspec with 1.0.

At least rubocop-ast's CI build fails for the master branch as it can't resolve dependencies.

[marcandre]

Oh oh, maybe not compatible after all? 😅

[pirj]

@marcandre That's odd. rubocop-rspec is rubocop-ast's development dependency, right?
I guess we have a circular dependency problem, rubocop-ast 1.0 -> rubocop 1.0, 'rubocop-rspec 1.44.1->rubocop < 1. What if you move the rubocop-rspecdependency declaration from gemspec to theGemfile, and point it to rubocop-rspec's master`?

Do you think it's time to start merging our 2.0 pulls https://github.com/rubocop-hq/rubocop-rspec/pulls?q=is%3Aopen+is%3Apr+milestone%3A2.0 @bquorning @Darhazer ?

[pirj]

There are some breaking changes (see CI failure when running rubocop-rspec against RuboCop's master https://app.circleci.com/pipelines/github/rubocop-hq/rubocop-rspec/580/workflows/2d22b1ca-ade8-4e41-a49d-50c80cc3a608/jobs/17604). We'll see if we'll be able to fix it quickly.

[pirj]

@bquorning @Darhazer It's TIME! https://github.com/rubocop-hq/rubocop/releases/tag/v1.0.0 🙌

[bquorning]

A quick release would be appreciated

Alas, I think it will be a couple of days…

I have opened a new issue for tracking the upgrade process: #1051

[marcandre]

I guess we have a circular dependency problem. What if you move the rubocop-rspecdependency declaration from gemspec to theGemfile, and point it to rubocop-rspec's master?

That won't work. What I can do is what the main rubocop gem did (unknowingly?) is to relax the version of rubocop-rspec I'm asking for and bundler will find an older version that didn't have this limitation (1.43.2). That's the only reason why this doesn't break the main gem too.

[pirj]

Sorry for the trouble, @marcandre.

[marcandre]

It's all good, this made me realize some issues with the setup of rubocop-ast. It's tricky!