Bump version to v1.43.2 #1022
Merged
Bump version to v1.43.2 #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shared-groups Skip files with shared groups in RSpec/FilePath
Fix subject nesting detection in RSpec/LeadingSubject
5 tasks
pirj
approved these changes
Aug 25, 2020
|
Oh no, this branch isn’t based on master. It’s just 3 commits on top of https://github.com/rubocop-hq/rubocop-rspec/tree/v1.43.1 |
|
This is where my knowledge of git merge commits fails to explain how things are possible. |
bquorning
force-pushed
the
1.43-bugfixes
branch
from
68a7c1a
to
fd7009b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1011 (comment), we have a couple of regression fixes that should be released before the next minor (or major) release goes out.
This branch cherry-picks the merge commits of #1009 and #1011 and changes the version number.
This branch will need to be merged into master afterwards, possibly manually (because of CHANGELOG conflicts), but the tagging and releasing will be done from fd7009b before the merge.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).