Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RSpec/EmptyExampleGroup's CustomIncludeMethods config option #969

Closed
1 task done
pirj opened this issue Jul 15, 2020 · 5 comments · Fixed by #1007
Closed
1 task done

Remove RSpec/EmptyExampleGroup's CustomIncludeMethods config option #969

pirj opened this issue Jul 15, 2020 · 5 comments · Fixed by #1007
Milestone
2.0

Comments

@pirj
Copy link
Member

pirj commented Jul 15, 2020 •
edited

It may be replaced with a global or cop-local configuration for RSpec aliases when #956 is implemented.

Bonus points:

  • find other such configuration options and fix in a similar way
@pirj pirj added this to the 2.0 milestone Jul 15, 2020
@pirj pirj changed the title Remove RSpec/EmptyExampleGroup's CustomIncludeMethods Remove RSpec/EmptyExampleGroup's CustomIncludeMethods config option Jul 15, 2020
@pirj pirj mentioned this issue Jul 21, 2020
Closed
@pirj pirj mentioned this issue Aug 19, 2020
Merged
6 tasks
@bquorning bquorning mentioned this issue Oct 22, 2020
Merged
@bquorning
Copy link
Collaborator

  • find other such configuration options and fix in a similar way

We should probably do this work before 2.0.

@pirj
Copy link
Member Author

pirj commented Nov 4, 2020

@bquorning This is done actually. I couldn't find any cop-specific RSpec DSL configuration apart from EmptyExampleGroup.

@bquorning
Copy link
Collaborator

I guess we can check the box and close this issue then?

@pirj
Copy link
Member Author

pirj commented Nov 4, 2020

It will be automatically resolved when #1007 is merged to master.
We'll have to go through our open tickets after releasing anyway, since e.g. there are numerous tickets resolved by #956, e.g. #333, which are not referenced by #956 as fixes #....

@pirj
Copy link
Member Author

pirj commented Nov 6, 2020

I wasn't automatically resolved for some reason. Let us quickly help you, Github.

@pirj pirj closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Drop RSpec/EmptyExampleGroup customization rubocop/rubocop-rspec
2 participants
@pirj @bquorning