Replace should-example with expect-example

rubocop · Apr 27, 2020 · ff6b291 · ff6b291
1 parent 03ce0a7
commit ff6b291
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/lib/rubocop/cop/rspec/named_subject.rb b/lib/rubocop/cop/rspec/named_subject.rb
@@ -6,11 +6,11 @@ module RSpec
       # Checks for explicitly referenced test subjects.
       #
       # RSpec lets you declare an "implicit subject" using `subject { ... }`
-      # which allows for tests like `it { should be_valid }`. If you need to
-      # reference your test subject you should explicitly name it using
-      # `subject(:your_subject_name) { ... }`. Your test subjects should be
-      # the most important object in your tests so they deserve a descriptive
-      # name.
+      # which allows for tests like `it { is_expected.to be_valid }`.
+      # If you need to reference your test subject you should explicitly
+      # name it using `subject(:your_subject_name) { ... }`. Your test subjects
+      # should be the most important object in your tests so they deserve
+      # a descriptive name.
       #
       # This cop can be configured in your configuration using the
       # `IgnoreSharedExamples` which will not report offenses for implicit
@@ -39,7 +39,7 @@ module RSpec
       #   RSpec.describe Foo do
       #     subject(:user) { described_class.new }
       #
-      #     it { should be_valid }
+      #     it { is_expected.to be_valid }
       #   end
       class NamedSubject < Cop
         MSG = 'Name your test subject if you need '\

diff --git a/manual/cops_rspec.md b/manual/cops_rspec.md
@@ -2120,11 +2120,11 @@ Enabled | No
 Checks for explicitly referenced test subjects.
 
 RSpec lets you declare an "implicit subject" using `subject { ... }`
-which allows for tests like `it { should be_valid }`. If you need to
-reference your test subject you should explicitly name it using
-`subject(:your_subject_name) { ... }`. Your test subjects should be
-the most important object in your tests so they deserve a descriptive
-name.
+which allows for tests like `it { is_expected.to be_valid }`.
+If you need to reference your test subject you should explicitly
+name it using `subject(:your_subject_name) { ... }`. Your test subjects
+should be the most important object in your tests so they deserve
+a descriptive name.
 
 This cop can be configured in your configuration using the
 `IgnoreSharedExamples` which will not report offenses for implicit
@@ -2155,7 +2155,7 @@ end
 RSpec.describe Foo do
   subject(:user) { described_class.new }
 
-  it { should be_valid }
+  it { is_expected.to be_valid }
 end
 ```