Skip to content

Commit

Permalink
Merge pull request #1178 from francois-ferrandis/expect-change-unsafe…
Browse files Browse the repository at this point in the history
…-autocorrect

Declare autocorrect as unsafe for `ExpectChange`
  • Loading branch information
pirj committed Aug 10, 2021
2 parents d705584 + 2332d42 commit fe60c94
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,7 @@

## Master (Unreleased)

* Declare autocorrect as unsafe for `ExpectChange`. ([@francois-ferrandis][])
* Fix each example for `RSpec/HookArgument`. ([@lokhi][])
* Exclude unrelated Rails directories from `RSpec/DescribeClass`. ([@MothOnMars][])
* Add `RSpec/ExcessiveDocstringSpacing` cop. ([@G-Rath][])
Expand Down Expand Up @@ -635,3 +636,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
[@MothOnMars]: https://github.com/MothOnMars
[@G-Rath]: https://github.com/G-Rath
[@dswij]: https://github.com/dswij
[@francois-ferrandis]: https://github.com/francois-ferrandis
2 changes: 2 additions & 0 deletions config/default.yml
Expand Up @@ -309,7 +309,9 @@ RSpec/ExpectChange:
SupportedStyles:
- method_call
- block
SafeAutoCorrect: false
VersionAdded: '1.22'
VersionChanged: 2.5.0
StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectChange

RSpec/ExpectInHook:
Expand Down
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/cops_rspec.adoc
Expand Up @@ -1366,9 +1366,9 @@ expect(name).to eq("John")

| Enabled
| Yes
| Yes
| Yes (Unsafe)
| 1.22
| -
| 2.5.0
|===

Checks for consistent style of change matcher.
Expand Down

0 comments on commit fe60c94

Please sign in to comment.