fixup! Extract helper class for moving nodes arround

rubocop · Apr 28, 2020 · 97be3a6 · 97be3a6
1 parent 146448b
commit 97be3a6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/lib/rubocop/cop/rspec/hooks_before_examples.rb b/lib/rubocop/cop/rspec/hooks_before_examples.rb
@@ -42,7 +42,9 @@ def on_block(node)
         def autocorrect(node)
           lambda do |corrector|
             first_example = find_first_example(node.parent)
-            RuboCop::RSpec::Corrector::MoveNode.new(node, corrector, processed_source).move_before(first_example)
+            RuboCop::RSpec::Corrector::MoveNode.new(
+              node, corrector, processed_source
+            ).move_before(first_example)
           end
         end
 

diff --git a/lib/rubocop/cop/rspec/leading_subject.rb b/lib/rubocop/cop/rspec/leading_subject.rb
@@ -56,7 +56,9 @@ def check_previous_nodes(node)
         def autocorrect(node)
           lambda do |corrector|
             first_node = find_first_offending_node(node)
-            RuboCop::RSpec::Corrector::MoveNode.new(node, corrector, processed_source).move_before(first_node)
+            RuboCop::RSpec::Corrector::MoveNode.new(
+              node, corrector, processed_source
+            ).move_before(first_node)
           end
         end
 

diff --git a/lib/rubocop/cop/rspec/let_before_examples.rb b/lib/rubocop/cop/rspec/let_before_examples.rb
@@ -49,7 +49,9 @@ def on_block(node)
         def autocorrect(node)
           lambda do |corrector|
             first_example = find_first_example(node.parent)
-            RuboCop::RSpec::Corrector::MoveNode.new(node, corrector, processed_source).move_before(first_example)
+            RuboCop::RSpec::Corrector::MoveNode.new(
+              node, corrector, processed_source
+            ).move_before(first_example)
           end
         end
 

diff --git a/lib/rubocop/rspec/corrector/move_node.rb b/lib/rubocop/rspec/corrector/move_node.rb
@@ -16,7 +16,7 @@ def initialize(node, corrector, processed_source)
           @processed_source = processed_source # used by RangeHelp
         end
 
-        def move_before(other)
+        def move_before(other) # rubocop:disable Metrics/AbcSize
           position = other.loc.expression
           indent = "\n" + ' ' * other.loc.column