rename NoLet -> MemoizedHelpersInExampleGroup

rubocop · Mar 20, 2020 · 7407c51 · 7407c51
1 parent 67e1242
commit 7407c51
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,7 +15,7 @@
 * Add `RSpec/RepeatedExampleGroupDescription` cop. ([@lazycoder9][])
 * Add block name and other lines to `RSpec/ScatteredSetup` message. ([@elebow][])
 * Fix `RSpec/RepeatedDescription` to take into account example metadata. ([@lazycoder9][])
-* Add `RSpec/NoLet` cop. ([@mockdeep][])
+* Add `RSpec/MemoizedHelpersInExampleGroup` cop. ([@mockdeep][])
 
 ## 1.37.1 (2019-12-16)
 

diff --git a/config/default.yml b/config/default.yml
@@ -343,11 +343,11 @@ RSpec/NestedGroups:
   Max: 3
   StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups
 
-RSpec/NoLet:
+RSpec/MemoizedHelpersInExampleGroup:
   Description: Checks for usage of `let` blocks in specs.
   Enabled: false
   AllowSubject: false
-  StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NoLet
+  StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MemoizedHelpersInExampleGroup
 
 RSpec/NotToNot:
   Description: Checks for consistent method usage for negating expectations.

diff --git a/lib/rubocop/cop/rspec/no_let.rb → ...spec/memoized_helpers_in_example_group.rb b/lib/rubocop/cop/rspec/no_let.rb → ...spec/memoized_helpers_in_example_group.rb
@@ -32,7 +32,7 @@ module RSpec
       # @example with AllowSubject configuration
       #
       #   # rubocop.yml
-      #   # RSpec/NoLet:
+      #   # RSpec/MemoizedHelpersInExampleGroup:
       #   #   AllowSubject: true
       #
       #   # bad
@@ -54,7 +54,7 @@ module RSpec
       #     end
       #   end
       #
-      class NoLet < Cop
+      class MemoizedHelpersInExampleGroup < Cop
         MSG = 'Avoid using `%<method>s` ' \
               '– use a method call or local variable instead.'
 

diff --git a/manual/cops.md b/manual/cops.md
@@ -65,7 +65,7 @@
 * [RSpec/MultipleSubjects](cops_rspec.md#rspecmultiplesubjects)
 * [RSpec/NamedSubject](cops_rspec.md#rspecnamedsubject)
 * [RSpec/NestedGroups](cops_rspec.md#rspecnestedgroups)
-* [RSpec/NoLet](cops_rspec.md#rspecnolet)
+* [RSpec/MemoizedHelpersInExampleGroup](cops_rspec.md#rspecnolet)
 * [RSpec/NotToNot](cops_rspec.md#rspecnottonot)
 * [RSpec/OverwritingSetup](cops_rspec.md#rspecoverwritingsetup)
 * [RSpec/Pending](cops_rspec.md#rspecpending)

diff --git a/manual/cops_rspec.md b/manual/cops_rspec.md
@@ -2266,7 +2266,7 @@ Max | `3` | Integer
 
 * [https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups](https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups)
 
-## RSpec/NoLet
+## RSpec/MemoizedHelpersInExampleGroup
 
 Enabled by default | Supports autocorrection
 --- | ---
@@ -2304,7 +2304,7 @@ end
 
 ```ruby
 # rubocop.yml
-# RSpec/NoLet:
+# RSpec/MemoizedHelpersInExampleGroup:
 #   AllowSubject: true
 
 # bad
@@ -2335,7 +2335,7 @@ AllowSubject | `false` | Boolean
 
 ### References
 
-* [https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NoLet](https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NoLet)
+* [https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MemoizedHelpersInExampleGroup](https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MemoizedHelpersInExampleGroup)
 
 ## RSpec/NotToNot
 

diff --git a/spec/rubocop/cop/rspec/no_let_spec.rb → ...memoized_helpers_in_example_group_spec.rb b/spec/rubocop/cop/rspec/no_let_spec.rb → ...memoized_helpers_in_example_group_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe RuboCop::Cop::RSpec::NoLet do
+RSpec.describe RuboCop::Cop::RSpec::MemoizedHelpersInExampleGroup do
   subject(:cop) { described_class.new(config) }
 
   let(:config) { RuboCop::Config.new }