Rename 'rspec_block?' -> 'example_or_hook_block?' in NamedSubject

rubocop · Aug 5, 2020 · 64ed0b4 · 64ed0b4
1 parent 46f0a05
commit 64ed0b4
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/rubocop/cop/rspec/named_subject.rb b/lib/rubocop/cop/rspec/named_subject.rb
@@ -45,7 +45,7 @@ class NamedSubject < Base
         MSG = 'Name your test subject if you need '\
               'to reference it explicitly.'
 
-        def_node_matcher :rspec_block?, <<-PATTERN
+        def_node_matcher :example_or_hook_block?, <<-PATTERN
           {
             #{Examples::ALL.block_pattern}
             #{RuboCop::RSpec::Language.block_pattern('#rspec_hooks')}
@@ -59,7 +59,9 @@ class NamedSubject < Base
         def_node_search :subject_usage, '$(send nil? :subject)'
 
         def on_block(node)
-          return if !rspec_block?(node) || ignored_shared_example?(node)
+          if !example_or_hook_block?(node) || ignored_shared_example?(node)
+            return
+          end
 
           subject_usage(node) do |subject_node|
             add_offense(subject_node.loc.selector)