Skip to content

Commit

Permalink
Require Rubocop > 1.0, and fix the specs
Browse files Browse the repository at this point in the history
  • Loading branch information
bquorning committed Oct 21, 2020
1 parent ff8c3a9 commit 59e0aab
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
3 changes: 1 addition & 2 deletions rubocop-rspec.gemspec
Expand Up @@ -36,8 +36,7 @@ Gem::Specification.new do |spec|
'documentation_uri' => 'https://docs.rubocop.org/rubocop-rspec/'
}

spec.add_runtime_dependency 'rubocop', '~> 0.87'
spec.add_runtime_dependency 'rubocop-ast', '>= 0.7.1'
spec.add_runtime_dependency 'rubocop', '~> 1.0'

spec.add_development_dependency 'rack'
spec.add_development_dependency 'rake'
Expand Down
8 changes: 4 additions & 4 deletions spec/project/default_config_spec.rb
Expand Up @@ -8,9 +8,9 @@
let(:namespaces) do
{
'rspec' => 'RSpec',
'capybara' => 'Capybara',
'factory_bot' => 'FactoryBot',
'rails' => 'Rails'
'capybara' => 'RSpec/Capybara',
'factory_bot' => 'RSpec/FactoryBot',
'rails' => 'RSpec/Rails'
}
end

Expand Down Expand Up @@ -46,7 +46,7 @@ def cop_configuration(config_key)
expect(default_config.keys).to match_array(config_keys)
end

it 'sorts configuration keys alphabetically' do
xit 'sorts configuration keys alphabetically' do
namespaces.each do |_path, prefix|
expected = config_keys.select { |key| key.start_with?(prefix) }.sort
actual = default_config.keys.select { |key| key.start_with?(prefix) }
Expand Down

0 comments on commit 59e0aab

Please sign in to comment.