Do not fail rubocop when using in generator #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Mar 26, 2023
|
Can you update docs/modules/ROOT/pages/usage.adoc as well? |
|
@koic thanks for your review. I incorporated your feedback. |
|
This looks good to me. Can you squash your commits into one? |
|
I did all changes in-browser. Could you squash directly when merging this pull request? See screenshot at https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request#merging-a-pull-request |
|
I know squash merge but I don't prefer it:
I'm in no rush to merge, so please squash when it's convenient for you :-) |
Without this, the generator would exit with an error, if it found any warning or less severe offenses. Related to rubocop#956
|
Ok, understood @koic. I squashed them. |
|
Thanks! |
tmaier
added a commit
to tmaier/rubocop-rails
that referenced
this pull request
Apr 5, 2023
Files not supported by rubocop would lead to an error, which in turn would mean that the rails generate command would fail. We are going to filter the files to ensure unsupported files are not sent to rubocop Followup for rubocop#961 and rubocop#956
tmaier
added a commit
to tmaier/rubocop-rails
that referenced
this pull request
Apr 5, 2023
Files not supported by rubocop would lead to an error, which in turn would mean that the rails generate command would fail. We are going to filter the files to ensure unsupported files are not sent to rubocop Follow-up for rubocop#961 and rubocop#956
tmaier
added a commit
to tmaier/rubocop-rails
that referenced
this pull request
Apr 12, 2023
Previously, the 'rails generate' command would send unsupported files to Rubocop,causing errors and failures in the process. To fix this, we added a filter that only sends parsable files to Rubocop. This commit updates the documentation to reflect this change, helping users avoid errors and complete 'rails generate' command successfully. Follow-up to rubocop#961 and rubocop#956
tmaier
added a commit
to tmaier/rubocop-rails
that referenced
this pull request
Apr 12, 2023
Previously, the 'rails generate' command would send unsupported files to Rubocop, causing errors and failures in the process. To fix this, we added a filter that only sends parsable files to Rubocop. This commit updates the documentation to reflect this change, helping users avoid errors and complete 'rails generate' command successfully. Follow-up to rubocop#961 and rubocop#956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the generator would exit with an error, if it found any error or warning